1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-fs-options-immutable

Browse Source 
* Reorder require() statements per test-writing guide
* Use common.mustNotCall() to check that callback is not invoked
* Use common.mustCall() to check that callback is invoked

PR-URL: https://github.com/nodejs/node/pull/13977
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
Rich Trott 2017-06-28 21:22:35 -07:00
parent 48660fbb9d
commit f05653dc45
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/parallel/test-fs-options-immutable.js
View File

@ -1,4 +1,5 @@
'use strict'; 'use strict';
const common = require('../common');
/* /*
* These tests make sure that the `options` object passed to these functions are * These tests make sure that the `options` object passed to these functions are
@ -7,10 +8,10 @@
* Refer: https://github.com/nodejs/node/issues/7655 * Refer: https://github.com/nodejs/node/issues/7655
*/ */
const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const path = require('path');
const fs = require('fs'); const fs = require('fs');
const path = require('path');
const errHandler = (e) => assert.ifError(e); const errHandler = (e) => assert.ifError(e);
const options = Object.freeze({}); const options = Object.freeze({});
common.refreshTmpDir(); common.refreshTmpDir();
@ -61,13 +62,15 @@ if (common.canCreateSymLink()) {
{ {
let watch; let watch;
assert.doesNotThrow(() => { assert.doesNotThrow(() => {
watch = fs.watch(__filename, options, common.noop); watch = fs.watch(__filename, options, common.mustNotCall());
}); });
watch.close(); watch.close();
} }
{ {
assert.doesNotThrow(() => fs.watchFile(__filename, options, common.noop)); assert.doesNotThrow(
() => fs.watchFile(__filename, options, common.mustNotCall())
);
fs.unwatchFile(__filename); fs.unwatchFile(__filename);
} }
@ -89,8 +92,8 @@ if (common.canCreateSymLink()) {
{ {
const fileName = path.resolve(common.tmpDir, 'streams'); const fileName = path.resolve(common.tmpDir, 'streams');
assert.doesNotThrow(() => { assert.doesNotThrow(() => {
fs.WriteStream(fileName, options).once('open', () => { fs.WriteStream(fileName, options).once('open', common.mustCall(() => {
assert.doesNotThrow(() => fs.ReadStream(fileName, options)); assert.doesNotThrow(() => fs.ReadStream(fileName, options));
}); }));
}); });
} }