1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: skip failing tests for osx mojave

Browse Source 
Refs: https://github.com/nodejs/node/issues/21679
PR-URL: https://github.com/nodejs/node/pull/23550
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This commit is contained in:
jn99 2018-10-12 10:36:32 -07:00 committed by Anna Henningsen
parent 5550510056
commit eff869fecc
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
4 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/common/index.js
View File

@ -56,6 +56,8 @@ const isOpenBSD = process.platform === 'openbsd';
const isLinux = process.platform === 'linux';
const isOSX = process.platform === 'darwin';
const isOSXMojave = isOSX && (os.release().startsWith('18'));
const enoughTestMem = os.totalmem() > 0x70000000; /* 1.75 Gb */
const cpus = os.cpus();
const enoughTestCpu = Array.isArray(cpus) &&
@ -712,6 +714,7 @@ module.exports = {
isMainThread,
isOpenBSD,
isOSX,
isOSXMojave,
isSunOS,
isWindows,
localIPv6Hosts,

25
test/known_issues/test-cluster-bind-privileged-port.js Normal file
View File

@ -0,0 +1,25 @@
'use strict';
const common = require('../common');
// This test should fail on macOS (10.14) due to an issue with privileged ports.
const assert = require('assert');
const cluster = require('cluster');
const net = require('net');
if (!common.isOSXMojave)
assert.fail('Code should fail only on macOS Mojave.');
if (cluster.isMaster) {
cluster.fork().on('exit', common.mustCall((exitCode) => {
assert.strictEqual(exitCode, 0);
}));
} else {
const s = net.createServer(common.mustNotCall());
s.listen(42, common.mustNotCall('listen should have failed'));
s.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'EACCES');
process.disconnect();
}));
}

5
test/parallel/test-cluster-bind-privileged-port.js
View File

@ -21,6 +21,11 @@
'use strict';
const common = require('../common');
// Skip on OS X Mojave. https://github.com/nodejs/node/issues/21679
if (common.isOSXMojave)
common.skip('bypass test for Mojave due to OSX issue');
if (common.isWindows)
common.skip('not reliable on Windows.');

5
test/parallel/test-cluster-shared-handle-bind-privileged-port.js
View File

@ -21,6 +21,11 @@
'use strict';
const common = require('../common');
// Skip on OS X Mojave. https://github.com/nodejs/node/issues/21679
if (common.isOSXMojave)
common.skip('bypass test for Mojave due to OSX issue');
if (common.isWindows)
common.skip('not reliable on Windows');