test: refactored context type err message to regex
PR-URL: https://github.com/nodejs/node/pull/12596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
parent
85a4e25775
commit
ef6a7cf2bc
@ -46,7 +46,7 @@ assert.strictEqual('lala', context.thing);
|
|||||||
// Issue GH-227:
|
// Issue GH-227:
|
||||||
assert.throws(function() {
|
assert.throws(function() {
|
||||||
vm.runInNewContext('', null, 'some.js');
|
vm.runInNewContext('', null, 'some.js');
|
||||||
}, TypeError);
|
}, /^TypeError: sandbox must be an object$/);
|
||||||
|
|
||||||
// Issue GH-1140:
|
// Issue GH-1140:
|
||||||
console.error('test runInContext signature');
|
console.error('test runInContext signature');
|
||||||
@ -62,9 +62,18 @@ assert.ok(gh1140Exception,
|
|||||||
'expected exception from runInContext signature test');
|
'expected exception from runInContext signature test');
|
||||||
|
|
||||||
// GH-558, non-context argument segfaults / raises assertion
|
// GH-558, non-context argument segfaults / raises assertion
|
||||||
[undefined, null, 0, 0.0, '', {}, []].forEach(function(e) {
|
const nonContextualSandboxErrorMsg =
|
||||||
assert.throws(function() { script.runInContext(e); }, TypeError);
|
/^TypeError: contextifiedSandbox argument must be an object\.$/;
|
||||||
assert.throws(function() { vm.runInContext('', e); }, TypeError);
|
const contextifiedSandboxErrorMsg =
|
||||||
|
/^TypeError: sandbox argument must have been converted to a context\.$/;
|
||||||
|
[
|
||||||
|
[undefined, nonContextualSandboxErrorMsg],
|
||||||
|
[null, nonContextualSandboxErrorMsg], [0, nonContextualSandboxErrorMsg],
|
||||||
|
[0.0, nonContextualSandboxErrorMsg], ['', nonContextualSandboxErrorMsg],
|
||||||
|
[{}, contextifiedSandboxErrorMsg], [[], contextifiedSandboxErrorMsg]
|
||||||
|
].forEach((e) => {
|
||||||
|
assert.throws(() => { script.runInContext(e[0]); }, e[1]);
|
||||||
|
assert.throws(() => { vm.runInContext('', e[0]); }, e[1]);
|
||||||
});
|
});
|
||||||
|
|
||||||
// Issue GH-693:
|
// Issue GH-693:
|
||||||
|
Loading…
x
Reference in New Issue
Block a user