1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactored context type err message to regex

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/12596
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Muhsin Abdul-Musawwir 2017-04-22 12:27:42 -07:00 committed by James M Snell
parent 85a4e25775
commit ef6a7cf2bc
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/parallel/test-vm-context.js
View File

@ -46,7 +46,7 @@ assert.strictEqual('lala', context.thing);
// Issue GH-227:
assert.throws(function() {
vm.runInNewContext('', null, 'some.js');
}, TypeError);
}, /^TypeError: sandbox must be an object$/);
// Issue GH-1140:
console.error('test runInContext signature');
@ -62,9 +62,18 @@ assert.ok(gh1140Exception,
'expected exception from runInContext signature test');
// GH-558, non-context argument segfaults / raises assertion
[undefined, null, 0, 0.0, '', {}, []].forEach(function(e) {
assert.throws(function() { script.runInContext(e); }, TypeError);
assert.throws(function() { vm.runInContext('', e); }, TypeError);
const nonContextualSandboxErrorMsg =
/^TypeError: contextifiedSandbox argument must be an object\.$/;
const contextifiedSandboxErrorMsg =
/^TypeError: sandbox argument must have been converted to a context\.$/;
[
[undefined, nonContextualSandboxErrorMsg],
[null, nonContextualSandboxErrorMsg], [0, nonContextualSandboxErrorMsg],
[0.0, nonContextualSandboxErrorMsg], ['', nonContextualSandboxErrorMsg],
[{}, contextifiedSandboxErrorMsg], [[], contextifiedSandboxErrorMsg]
].forEach((e) => {
assert.throws(() => { script.runInContext(e[0]); }, e[1]);
assert.throws(() => { vm.runInContext('', e[0]); }, e[1]);
});
// Issue GH-693: