1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests: fix process.kill pid test.

Browse Source 
Prevent test-process-kill-pid.js tests suite from sending SIGHUP
to its process group, which was causing the test runner to terminate.

Fix jenkins' jobs for nodejs-master.

Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
This commit is contained in:
Julien Gilli 2014-07-28 17:19:03 -07:00 committed by Timothy J Fontaine
parent e1fb1b58f9
commit ef3c4ed3dd
1 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
test/simple/test-process-kill-pid.js
View File

@ -43,7 +43,9 @@ process.on('exit', function(code) {
//
// Nan, Infinity, -Infinity: TypeError
//
// 0, process.pid: ourself
// 0: our group process
//
// process.pid: ourself
assert.throws(function() { process.kill('SIGTERM'); }, TypeError);
assert.throws(function() { process.kill(String(process.pid)); }, TypeError);
@ -61,4 +63,31 @@ process.once('SIGHUP', function() {
process.kill(process.pid, 'SIGHUP');
});
/*
* Monkey patch _kill so that, in the specific case
* when we want to test sending a signal to pid 0,
* we don't actually send the signal to the process group.
* Otherwise, it could cause a lot of trouble, like terminating
* the test runner, or any other process that belongs to the
* same process group as this test.
*/
var origKill = process._kill;
process._kill = function(pid, sig) {
/*
* make sure we patch _kill only when
* we want to test sending a signal
* to the process group.
*/
assert.strictEqual(pid, 0);
// make sure that _kill is passed the correct args types
assert(typeof pid === 'number');
assert(typeof sig === 'number');
// un-monkey patch process._kill
process._kill = origKill;
process._kill(process.pid, sig);
}
process.kill(0, 'SIGHUP');