1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: dynamic port in cluster ipc throw

Browse Source 
Removed common.PORT from test-cluster-ipc-throw to eliminate the
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: https://github.com/nodejs/node/pull/12571
Ref: https://github.com/nodejs/node/issues/12376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Sebastian Plesciuc 2017-04-21 18:05:28 +03:00 committed by James M Snell
parent c005ebb0ce
commit ee8183ed85
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/parallel/test-cluster-ipc-throw.js
View File

@ -2,20 +2,23 @@
const common = require('../common'); const common = require('../common');
const http = require('http'); const http = require('http');
const cluster = require('cluster'); const cluster = require('cluster');
const assert = require('assert');
cluster.schedulingPolicy = cluster.SCHED_RR; cluster.schedulingPolicy = cluster.SCHED_RR;
const server = http.createServer(); const server = http.createServer();
if (cluster.isMaster) { if (cluster.isMaster) {
server.listen(common.PORT); server.listen({port: 0}, common.mustCall(() => {
const worker = cluster.fork(); const worker = cluster.fork({PORT: server.address().port});
worker.on('exit', common.mustCall(() => { worker.on('exit', common.mustCall(() => {
server.close(); server.close();
}));
})); }));
} else { } else {
assert(process.env.PORT);
process.on('uncaughtException', common.mustCall((e) => {})); process.on('uncaughtException', common.mustCall((e) => {}));
server.listen(common.PORT); server.listen(process.env.PORT);
server.on('error', common.mustCall((e) => { server.on('error', common.mustCall((e) => {
cluster.worker.disconnect(); cluster.worker.disconnect();
throw e; throw e;