From ee2a7703e78a410fff8051dd842ef1352f73af31 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sun, 13 May 2018 09:28:25 -0400 Subject: [PATCH] test: disable colors in test-assert-checktag.js When test/parallel/test-assert-checktag.js is run with a TTY as stdout, color codes in assertion messages cause the test to fail. This commit disables colors when stdout is a TTY. PR-URL: https://github.com/nodejs/node/pull/20695 Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat Reviewed-By: Daniel Bevenius Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- test/parallel/test-assert-checktag.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/parallel/test-assert-checktag.js b/test/parallel/test-assert-checktag.js index 38ebaa1a143..70a67e15d3f 100644 --- a/test/parallel/test-assert-checktag.js +++ b/test/parallel/test-assert-checktag.js @@ -2,6 +2,12 @@ require('../common'); const assert = require('assert'); +// Disable colored output to prevent color codes from breaking assertion +// message comparisons. This should only be an issue when process.stdout +// is a TTY. +if (process.stdout.isTTY) + process.env.NODE_DISABLE_COLORS = '1'; + // Turn off no-restricted-properties because we are testing deepEqual! /* eslint-disable no-restricted-properties */