1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add url type check in Module options

Browse Source 
The code coverage in `root/internal/vm/Module.js` lacked test coverage
for the url options paramter. The test adds a check to ensure error
is thrown.

PR-URL: https://github.com/nodejs/node/pull/18664
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
JiaHerr Tee 2018-02-08 18:38:38 -05:00 committed by Gus Caplan
parent 523a1550a3
commit edffad075e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-vm-module-errors.js
View File

@ -44,7 +44,7 @@ async function checkArgType() {
}); });
for (const invalidOptions of [ for (const invalidOptions of [
0, 1, null, true, 'str', () => {}, Symbol.iterator 0, 1, null, true, 'str', () => {}, { url: 0 }, Symbol.iterator
]) { ]) {
common.expectsError(() => { common.expectsError(() => {
new Module('', invalidOptions); new Module('', invalidOptions);