test: fix test for inherited properties on vm

The known issue is fixed with
https://github.com/nodejs/node/pull/16293.

The text needs to call `Object.hasOwnProperty(this)`
instead of `this.hasOwnProperty()`, otherwise `this` is
from the wrong context is used.

Add a second test case taken verbatim from issue
https://github.com/nodejs/node/issues/5350

PR-URL: https://github.com/nodejs/node/pull/16411
Fixes: https://github.com/nodejs/node/issues/5350
Ref: https://github.com/nodejs/node/pull/16293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Franziska Hinkelmann 2017-10-23 16:06:35 +02:00
parent 9c6f6b0633
commit ed116dc3c6
2 changed files with 38 additions and 20 deletions

View File

@ -1,20 +0,0 @@
'use strict';
// Ref: https://github.com/nodejs/node/issues/5350
require('../common');
const vm = require('vm');
const assert = require('assert');
const base = {
propBase: 1
};
const sandbox = Object.create(base, {
propSandbox: { value: 3 }
});
const context = vm.createContext(sandbox);
const result = vm.runInContext('this.hasOwnProperty("propBase");', context);
assert.strictEqual(result, false);

View File

@ -0,0 +1,38 @@
'use strict';
require('../common');
const vm = require('vm');
const assert = require('assert');
let base = {
propBase: 1
};
let sandbox = Object.create(base, {
propSandbox: { value: 3 }
});
const context = vm.createContext(sandbox);
let result = vm.runInContext('Object.hasOwnProperty(this, "propBase");',
context);
assert.strictEqual(result, false);
// Ref: https://github.com/nodejs/node/issues/5350
base = Object.create(null);
base.x = 1;
base.y = 2;
sandbox = Object.create(base);
sandbox.z = 3;
assert.deepStrictEqual(Object.keys(sandbox), ['z']);
const code = 'x = 0; z = 4;';
result = vm.runInNewContext(code, sandbox);
assert.strictEqual(result, 4);
// Check that y is not an own property.
assert.deepStrictEqual(Object.keys(sandbox), ['z', 'x']);