1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-http-dns-error

Browse Source 
Replace var with const and use strictEqual().

PR-URL: https://github.com/nodejs/node/pull/10062
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This commit is contained in:
Outsider 2016-12-01 13:08:04 -06:00 committed by Rich Trott
parent 1d6c2647de
commit ecf7bb70a5
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/parallel/test-http-dns-error.js
View File

@ -1,8 +1,8 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');
var http = require('http');
const http = require('http');
if (common.hasCrypto) {
var https = require('https');
@ -10,7 +10,7 @@ if (common.hasCrypto) {
common.skip('missing crypto');
}
var host = '*'.repeat(256);
const host = '*'.repeat(256);
function do_not_call() {
throw new Error('This function should not have been called.');
@ -20,15 +20,15 @@ function test(mod) {
// Bad host name should not throw an uncatchable exception.
// Ensure that there is time to attach an error listener.
var req1 = mod.get({host: host, port: 42}, do_not_call);
const req1 = mod.get({host: host, port: 42}, do_not_call);
req1.on('error', common.mustCall(function(err) {
assert.equal(err.code, 'ENOTFOUND');
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// http.get() called req1.end() for us
var req2 = mod.request({method: 'GET', host: host, port: 42}, do_not_call);
const req2 = mod.request({method: 'GET', host: host, port: 42}, do_not_call);
req2.on('error', common.mustCall(function(err) {
assert.equal(err.code, 'ENOTFOUND');
assert.strictEqual(err.code, 'ENOTFOUND');
}));
req2.end();
}