1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: name all builtin init functions Initialize

Browse Source 
This commit renames a few of the builtin modules init functions to
Initialize for consistency.

PR-URL: https://github.com/nodejs/node/pull/19550
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Daniel Bevenius 2018-03-23 09:38:16 +01:00
parent 0d5720bf03
commit ebbf393600
15 changed files with 59 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/inspector_js_api.cc
View File

@ -296,8 +296,8 @@ void Url(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(OneByteString(env->isolate(), url.c_str())); args.GetReturnValue().Set(OneByteString(env->isolate(), url.c_str()));
} }
void InitInspectorBindings(Local<Object> target, Local<Value> unused, void Initialize(Local<Object> target, Local<Value> unused,
Local<Context> context, void* priv) { Local<Context> context, void* priv) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
{ {
auto obj = Object::New(env->isolate()); auto obj = Object::New(env->isolate());
@ -341,4 +341,4 @@ void InitInspectorBindings(Local<Object> target, Local<Value> unused,
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector,
node::inspector::InitInspectorBindings); node::inspector::Initialize);

4
src/node.cc
View File

@ -4647,7 +4647,7 @@ void RegisterBuiltinModules() {
} // namespace node } // namespace node
#if !HAVE_INSPECTOR #if !HAVE_INSPECTOR
void InitEmptyBindings() {} void Initialize() {}
NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, InitEmptyBindings) NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, Initialize)
#endif // !HAVE_INSPECTOR #endif // !HAVE_INSPECTOR

4
src/node_config.cc
View File

@ -36,7 +36,7 @@ using v8::Value;
value, ReadOnly).FromJust(); \ value, ReadOnly).FromJust(); \
} while (0) } while (0)
static void InitConfig(Local<Object> target, static void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context) { Local<Context> context) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
@ -138,4 +138,4 @@ static void InitConfig(Local<Object> target,
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(config, node::InitConfig) NODE_BUILTIN_MODULE_CONTEXT_AWARE(config, node::Initialize)

8
src/node_contextify.cc
View File

@ -1143,9 +1143,9 @@ class ContextifyScript : public BaseObject {
}; };
void InitContextify(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context) { Local<Context> context) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
ContextifyContext::Init(env, target); ContextifyContext::Init(env, target);
ContextifyScript::Init(env, target); ContextifyScript::Init(env, target);
@ -1154,4 +1154,4 @@ void InitContextify(Local<Object> target,
} // namespace contextify } // namespace contextify
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(contextify, node::contextify::InitContextify) NODE_BUILTIN_MODULE_CONTEXT_AWARE(contextify, node::contextify::Initialize)

4
src/node_crypto.cc
View File

@ -5778,7 +5778,7 @@ void SetFipsCrypto(const FunctionCallbackInfo<Value>& args) {
} }
#endif /* NODE_FIPS_MODE */ #endif /* NODE_FIPS_MODE */
void InitCrypto(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context, Local<Context> context,
void* priv) { void* priv) {
@ -5852,4 +5852,4 @@ void InitCrypto(Local<Object> target,
} // namespace crypto } // namespace crypto
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(crypto, node::crypto::InitCrypto) NODE_BUILTIN_MODULE_CONTEXT_AWARE(crypto, node::crypto::Initialize)

10
src/node_file.cc
View File

@ -1857,10 +1857,10 @@ static void Mkdtemp(const FunctionCallbackInfo<Value>& args) {
} }
} }
void InitFs(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context, Local<Context> context,
void* priv) { void* priv) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "access", Access); env->SetMethod(target, "access", Access);
@ -1976,4 +1976,4 @@ void InitFs(Local<Object> target,
} // end namespace node } // end namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(fs, node::fs::InitFs) NODE_BUILTIN_MODULE_CONTEXT_AWARE(fs, node::fs::Initialize)

10
src/node_http_parser.cc
View File

@ -728,10 +728,10 @@ const struct http_parser_settings Parser::settings = {
}; };
void InitHttpParser(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context, Local<Context> context,
void* priv) { void* priv) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
Local<FunctionTemplate> t = env->NewFunctionTemplate(Parser::New); Local<FunctionTemplate> t = env->NewFunctionTemplate(Parser::New);
t->InstanceTemplate()->SetInternalFieldCount(1); t->InstanceTemplate()->SetInternalFieldCount(1);
@ -778,4 +778,4 @@ void InitHttpParser(Local<Object> target,
} // anonymous namespace } // anonymous namespace
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(http_parser, node::InitHttpParser) NODE_BUILTIN_MODULE_CONTEXT_AWARE(http_parser, node::Initialize)

10
src/node_i18n.cc
View File

@ -852,10 +852,10 @@ static void GetStringWidth(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(width); args.GetReturnValue().Set(width);
} }
void Init(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context, Local<Context> context,
void* priv) { void* priv) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "toUnicode", ToUnicode); env->SetMethod(target, "toUnicode", ToUnicode);
env->SetMethod(target, "toASCII", ToASCII); env->SetMethod(target, "toASCII", ToASCII);
@ -875,6 +875,6 @@ void Init(Local<Object> target,
} // namespace i18n } // namespace i18n
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(icu, node::i18n::Init) NODE_BUILTIN_MODULE_CONTEXT_AWARE(icu, node::i18n::Initialize)
#endif // NODE_HAVE_I18N_SUPPORT #endif // NODE_HAVE_I18N_SUPPORT

8
src/node_perf.cc
View File

@ -372,9 +372,9 @@ void Timerify(const FunctionCallbackInfo<Value>& args) {
} }
void Init(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context) { Local<Context> context) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
Isolate* isolate = env->isolate(); Isolate* isolate = env->isolate();
performance_state* state = env->performance_state(); performance_state* state = env->performance_state();
@ -443,4 +443,4 @@ void Init(Local<Object> target,
} // namespace performance } // namespace performance
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(performance, node::performance::Init) NODE_BUILTIN_MODULE_CONTEXT_AWARE(performance, node::performance::Initialize)

8
src/node_serdes.cc
View File

@ -424,9 +424,9 @@ void DeserializerContext::ReadRawBytes(
args.GetReturnValue().Set(offset); args.GetReturnValue().Set(offset);
} }
void InitializeSerdesBindings(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context) { Local<Context> context) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
Local<FunctionTemplate> ser = Local<FunctionTemplate> ser =
env->NewFunctionTemplate(SerializerContext::New); env->NewFunctionTemplate(SerializerContext::New);
@ -483,4 +483,4 @@ void InitializeSerdesBindings(Local<Object> target,
} // anonymous namespace } // anonymous namespace
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(serdes, node::InitializeSerdesBindings) NODE_BUILTIN_MODULE_CONTEXT_AWARE(serdes, node::Initialize)

10
src/node_trace_events.cc
View File

@ -132,10 +132,10 @@ static void CategoryGroupEnabled(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(*category_group_enabled > 0); args.GetReturnValue().Set(*category_group_enabled > 0);
} }
void InitializeTraceEvents(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context, Local<Context> context,
void* priv) { void* priv) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "emit", Emit); env->SetMethod(target, "emit", Emit);
@ -144,4 +144,4 @@ void InitializeTraceEvents(Local<Object> target,
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(trace_events, node::InitializeTraceEvents) NODE_BUILTIN_MODULE_CONTEXT_AWARE(trace_events, node::Initialize)

10
src/node_url.cc
View File

@ -2290,10 +2290,10 @@ static void SetURLConstructor(const FunctionCallbackInfo<Value>& args) {
env->set_url_constructor_function(args[0].As<Function>()); env->set_url_constructor_function(args[0].As<Function>());
} }
static void Init(Local<Object> target, static void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context, Local<Context> context,
void* priv) { void* priv) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "parse", Parse); env->SetMethod(target, "parse", Parse);
env->SetMethod(target, "encodeAuth", EncodeAuthSet); env->SetMethod(target, "encodeAuth", EncodeAuthSet);
@ -2313,4 +2313,4 @@ static void Init(Local<Object> target,
} // namespace url } // namespace url
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(url, node::url::Init) NODE_BUILTIN_MODULE_CONTEXT_AWARE(url, node::url::Initialize)

8
src/node_v8.cc
View File

@ -119,9 +119,9 @@ void SetFlagsFromString(const FunctionCallbackInfo<Value>& args) {
} }
void InitializeV8Bindings(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context) { Local<Context> context) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "cachedDataVersionTag", CachedDataVersionTag); env->SetMethod(target, "cachedDataVersionTag", CachedDataVersionTag);
@ -201,4 +201,4 @@ void InitializeV8Bindings(Local<Object> target,
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(v8, node::InitializeV8Bindings) NODE_BUILTIN_MODULE_CONTEXT_AWARE(v8, node::Initialize)

10
src/node_zlib.cc
View File

@ -681,10 +681,10 @@ class ZCtx : public AsyncWrap {
}; };
void InitZlib(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context, Local<Context> context,
void* priv) { void* priv) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
Local<FunctionTemplate> z = env->NewFunctionTemplate(ZCtx::New); Local<FunctionTemplate> z = env->NewFunctionTemplate(ZCtx::New);
@ -709,4 +709,4 @@ void InitZlib(Local<Object> target,
} // anonymous namespace } // anonymous namespace
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(zlib, node::InitZlib) NODE_BUILTIN_MODULE_CONTEXT_AWARE(zlib, node::Initialize)

8
src/uv.cc
View File

@ -50,9 +50,9 @@ void ErrName(const FunctionCallbackInfo<Value>& args) {
} }
void InitializeUV(Local<Object> target, void Initialize(Local<Object> target,
Local<Value> unused, Local<Value> unused,
Local<Context> context) { Local<Context> context) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
Isolate* isolate = env->isolate(); Isolate* isolate = env->isolate();
target->Set(FIXED_ONE_BYTE_STRING(isolate, "errname"), target->Set(FIXED_ONE_BYTE_STRING(isolate, "errname"),
@ -82,4 +82,4 @@ void InitializeUV(Local<Object> target,
} // anonymous namespace } // anonymous namespace
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(uv, node::InitializeUV) NODE_BUILTIN_MODULE_CONTEXT_AWARE(uv, node::Initialize)