1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: update test-http-upgrade-client to use countdown

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17339
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit is contained in:
Mithun Sasidharan 2017-11-27 12:44:12 +05:30 committed by Jon Moss
parent 2afd4e779c
commit eb19c6b39f
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/parallel/test-http-upgrade-client.js
View File

@ -29,6 +29,7 @@ const assert = require('assert');
const http = require('http'); const http = require('http');
const net = require('net'); const net = require('net');
const Countdown = require('../common/countdown');
// Create a TCP server // Create a TCP server
const srv = net.createServer(function(c) { const srv = net.createServer(function(c) {
@ -60,7 +61,8 @@ srv.listen(0, '127.0.0.1', common.mustCall(function() {
['Origin', 'http://www.websocket.org'] ['Origin', 'http://www.websocket.org']
] ]
]; ];
let left = headers.length; const countdown = new Countdown(headers.length, () => srv.close());
headers.forEach(function(h) { headers.forEach(function(h) {
const req = http.get({ const req = http.get({
port: port, port: port,
@ -87,8 +89,7 @@ srv.listen(0, '127.0.0.1', common.mustCall(function() {
assert.deepStrictEqual(expectedHeaders, res.headers); assert.deepStrictEqual(expectedHeaders, res.headers);
socket.end(); socket.end();
if (--left === 0) countdown.dec();
srv.close();
})); }));
req.on('close', common.mustCall(function() { req.on('close', common.mustCall(function() {
assert.strictEqual(sawUpgrade, true); assert.strictEqual(sawUpgrade, true);