1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: remove unnecessary ToLocalChecked call

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/36523
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Daniel Bevenius 2020-12-15 06:17:55 +01:00
parent e51267bd4d
commit eb14b10370
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/node_buffer.cc
View File

@ -496,18 +496,19 @@ void StringSlice(const FunctionCallbackInfo<Value>& args) {
size_t length = end - start; size_t length = end - start;
Local<Value> error; Local<Value> error;
MaybeLocal<Value> ret = MaybeLocal<Value> maybe_ret =
StringBytes::Encode(isolate, StringBytes::Encode(isolate,
buffer.data() + start, buffer.data() + start,
length, length,
encoding, encoding,
&error); &error);
if (ret.IsEmpty()) { Local<Value> ret;
if (!maybe_ret.ToLocal(&ret)) {
CHECK(!error.IsEmpty()); CHECK(!error.IsEmpty());
isolate->ThrowException(error); isolate->ThrowException(error);
return; return;
} }
args.GetReturnValue().Set(ret.ToLocalChecked()); args.GetReturnValue().Set(ret);
} }