1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove deepStrictEqual() third argument

Browse Source 
The call to assert.deepStrictEqual() has a string literal for its third
argument. Unfortunately, a side effect of that is that the values of the
first two arguments are not displayed if there is an AssertionError.
That information is useful for debugging.

PR-URL: https://github.com/nodejs/node/pull/20702
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Francesco Falanga 2018-05-13 18:29:25 +02:00 committed by Rich Trott
parent 0e9ea35e39
commit eafb30ccbf
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-net-socket-local-address.js
View File

@ -17,8 +17,8 @@ const server = net.createServer((socket) => {
});
server.on('close', common.mustCall(() => {
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts,
'client and server should agree on the ports used');
// client and server should agree on the ports used
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts);
assert.strictEqual(2, conns);
}));