1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: check error and cleanups in test-fs-read-buffer

Browse Source 
Use arrow functions and prefer `strictEqual` over `deepStrictEqual`
where it works.

PR-URL: https://github.com/nodejs/node/pull/10611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
Anna Henningsen 2017-01-04 17:27:22 +01:00 committed by James M Snell
parent 334be0feba
commit eab95630f1
2 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/parallel/test-fs-read-buffer.js
View File

@ -16,6 +16,7 @@ function test(bufferAsync, bufferSync, expected) {
expected.length, expected.length,
0, 0,
common.mustCall((err, bytesRead) => { common.mustCall((err, bytesRead) => {
assert.ifError(err);
assert.strictEqual(bytesRead, expected.length); assert.strictEqual(bytesRead, expected.length);
assert.deepStrictEqual(bufferAsync, Buffer.from(expected)); assert.deepStrictEqual(bufferAsync, Buffer.from(expected));
})); }));

24
test/parallel/test-fs-write-buffer.js
View File

@ -10,17 +10,17 @@ common.refreshTmpDir();
// fs.write with all parameters provided: // fs.write with all parameters provided:
{ {
const filename = path.join(common.tmpDir, 'write1.txt'); const filename = path.join(common.tmpDir, 'write1.txt');
fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) { fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
assert.ifError(err); assert.ifError(err);
const cb = common.mustCall(function(err, written) { const cb = common.mustCall((err, written) => {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(expected.length, written); assert.strictEqual(expected.length, written);
fs.closeSync(fd); fs.closeSync(fd);
var found = fs.readFileSync(filename, 'utf8'); var found = fs.readFileSync(filename, 'utf8');
assert.deepStrictEqual(expected.toString(), found); assert.strictEqual(expected.toString(), found);
}); });
fs.write(fd, expected, 0, expected.length, null, cb); fs.write(fd, expected, 0, expected.length, null, cb);
@ -30,17 +30,17 @@ common.refreshTmpDir();
// fs.write with a buffer, without the length parameter: // fs.write with a buffer, without the length parameter:
{ {
const filename = path.join(common.tmpDir, 'write2.txt'); const filename = path.join(common.tmpDir, 'write2.txt');
fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) { fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
assert.ifError(err); assert.ifError(err);
const cb = common.mustCall(function(err, written) { const cb = common.mustCall((err, written) => {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(2, written); assert.strictEqual(2, written);
fs.closeSync(fd); fs.closeSync(fd);
const found = fs.readFileSync(filename, 'utf8'); const found = fs.readFileSync(filename, 'utf8');
assert.deepStrictEqual('lo', found); assert.strictEqual('lo', found);
}); });
fs.write(fd, Buffer.from('hello'), 3, cb); fs.write(fd, Buffer.from('hello'), 3, cb);
@ -90,17 +90,17 @@ common.refreshTmpDir();
// fs.write with offset and length passed as undefined followed by the callback: // fs.write with offset and length passed as undefined followed by the callback:
{ {
const filename = path.join(common.tmpDir, 'write5.txt'); const filename = path.join(common.tmpDir, 'write5.txt');
fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) { fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
assert.ifError(err); assert.ifError(err);
const cb = common.mustCall(function(err, written) { const cb = common.mustCall((err, written) => {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(expected.length, written); assert.strictEqual(expected.length, written);
fs.closeSync(fd); fs.closeSync(fd);
const found = fs.readFileSync(filename, 'utf8'); const found = fs.readFileSync(filename, 'utf8');
assert.deepStrictEqual(expected.toString(), found); assert.strictEqual(expected.toString(), found);
}); });
fs.write(fd, expected, undefined, undefined, cb); fs.write(fd, expected, undefined, undefined, cb);
@ -110,17 +110,17 @@ common.refreshTmpDir();
// fs.write with a Uint8Array, without the offset and length parameters: // fs.write with a Uint8Array, without the offset and length parameters:
{ {
const filename = path.join(common.tmpDir, 'write6.txt'); const filename = path.join(common.tmpDir, 'write6.txt');
fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) { fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
assert.ifError(err); assert.ifError(err);
const cb = common.mustCall(function(err, written) { const cb = common.mustCall((err, written) => {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(expected.length, written); assert.strictEqual(expected.length, written);
fs.closeSync(fd); fs.closeSync(fd);
const found = fs.readFileSync(filename, 'utf8'); const found = fs.readFileSync(filename, 'utf8');
assert.deepStrictEqual(expected.toString(), found); assert.strictEqual(expected.toString(), found);
}); });
fs.write(fd, Uint8Array.from(expected), cb); fs.write(fd, Uint8Array.from(expected), cb);