1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tty: fix console printing on Windows

Browse Source 
This broke writing non-ASCII data to the console on Windows because
the result would be codepage-dependent.

This partially reverts 8b751f7eb7b05a0b27f52e2288a636fdd78e9ecb.

Fixes: https://github.com/nodejs/node/issues/18189
Refs: https://github.com/nodejs/node/pull/18019

PR-URL: https://github.com/nodejs/node/pull/18214
Fixes: https://github.com/nodejs/node/issues/18189
Refs: https://github.com/nodejs/node/pull/18019
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Anna Henningsen 2018-01-17 22:55:23 +01:00 committed by Ruben Bridgewater
parent fe94394b99
commit ea7400c1bd
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/tty.js
View File

@ -24,7 +24,6 @@
const util = require('util'); const util = require('util');
const net = require('net'); const net = require('net');
const { TTY, isTTY } = process.binding('tty_wrap'); const { TTY, isTTY } = process.binding('tty_wrap');
const { makeSyncWrite } = require('internal/net');
const { inherits } = util; const { inherits } = util;
const errnoException = util._errnoException; const errnoException = util._errnoException;
const errors = require('internal/errors'); const errors = require('internal/errors');
@ -92,8 +91,6 @@ function WriteStream(fd) {
// even though it was originally intended to change in v1.0.2 (Libuv 1.2.1). // even though it was originally intended to change in v1.0.2 (Libuv 1.2.1).
// Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671 // Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
this._handle.setBlocking(true); this._handle.setBlocking(true);
this._writev = null;
this._write = makeSyncWrite(fd);
var winSize = new Array(2); var winSize = new Array(2);
var err = this._handle.getWindowSize(winSize); var err = this._handle.getWindowSize(winSize);