1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: elevate repeated use of v8 namespaced type

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/24427
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This commit is contained in:
Shubham Urkade 2018-11-17 17:49:53 +05:30 committed by Refael Ackermann
parent 23e692813f
commit ea655191d3
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/inspector_agent.cc
View File

@ -37,6 +37,7 @@ using v8::Function;
using v8::HandleScope; using v8::HandleScope;
using v8::Isolate; using v8::Isolate;
using v8::Local; using v8::Local;
using v8::Message;
using v8::Object; using v8::Object;
using v8::String; using v8::String;
using v8::Value; using v8::Value;
@ -362,7 +363,7 @@ class SameThreadInspectorSession : public InspectorSession {
}; };
void NotifyClusterWorkersDebugEnabled(Environment* env) { void NotifyClusterWorkersDebugEnabled(Environment* env) {
v8::Isolate* isolate = env->isolate(); Isolate* isolate = env->isolate();
HandleScope handle_scope(isolate); HandleScope handle_scope(isolate);
auto context = env->context(); auto context = env->context();
@ -512,7 +513,7 @@ class NodeInspectorClient : public V8InspectorClient {
} }
} }
void FatalException(Local<Value> error, Local<v8::Message> message) { void FatalException(Local<Value> error, Local<Message> message) {
Isolate* isolate = env_->isolate(); Isolate* isolate = env_->isolate();
Local<Context> context = env_->context(); Local<Context> context = env_->context();
@ -762,7 +763,7 @@ void Agent::WaitForDisconnect() {
} }
} }
void Agent::FatalException(Local<Value> error, Local<v8::Message> message) { void Agent::FatalException(Local<Value> error, Local<Message> message) {
if (!IsListening()) if (!IsListening())
return; return;
client_->FatalException(error, message); client_->FatalException(error, message);
@ -774,8 +775,8 @@ void Agent::PauseOnNextJavascriptStatement(const std::string& reason) {
} }
void Agent::RegisterAsyncHook(Isolate* isolate, void Agent::RegisterAsyncHook(Isolate* isolate,
v8::Local<v8::Function> enable_function, Local<Function> enable_function,
v8::Local<v8::Function> disable_function) { Local<Function> disable_function) {
enable_async_hook_function_.Reset(isolate, enable_function); enable_async_hook_function_.Reset(isolate, enable_function);
disable_async_hook_function_.Reset(isolate, disable_function); disable_async_hook_function_.Reset(isolate, disable_function);
if (pending_enable_async_hook_) { if (pending_enable_async_hook_) {
@ -850,7 +851,7 @@ void Agent::RequestIoThreadStart() {
// continuous JS code) and to wake up libuv thread (in case Node is waiting // continuous JS code) and to wake up libuv thread (in case Node is waiting
// for IO events) // for IO events)
uv_async_send(&start_io_thread_async); uv_async_send(&start_io_thread_async);
v8::Isolate* isolate = parent_env_->isolate(); Isolate* isolate = parent_env_->isolate();
v8::Platform* platform = parent_env_->isolate_data()->platform(); v8::Platform* platform = parent_env_->isolate_data()->platform();
platform->CallOnForegroundThread(isolate, new StartIoTask(this)); platform->CallOnForegroundThread(isolate, new StartIoTask(this));
isolate->RequestInterrupt(StartIoInterrupt, this); isolate->RequestInterrupt(StartIoInterrupt, this);