1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

module: introduce defaultModuleName in module.js

Browse Source 
This commit adds a constant named defaultModuleName to avoid duplicating
it in the Module constructor function.

PR-URL: https://github.com/nodejs/node/pull/20709
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Daniel Bevenius 2018-05-14 11:50:59 +02:00
parent 2b8cd93246
commit ea01d305f6
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/internal/vm/module.js
View File

@ -48,6 +48,7 @@ const linkingStatusMap = new WeakMap();
const initImportMetaMap = new WeakMap(); const initImportMetaMap = new WeakMap();
// ModuleWrap -> vm.Module // ModuleWrap -> vm.Module
const wrapToModuleMap = new WeakMap(); const wrapToModuleMap = new WeakMap();
const defaultModuleName = 'vm:module';
class Module { class Module {
constructor(src, options = {}) { constructor(src, options = {}) {
@ -82,13 +83,13 @@ class Module {
} }
url = new URL(url).href; url = new URL(url).href;
} else if (context === undefined) { } else if (context === undefined) {
url = `vm:module(${globalModuleId++})`; url = `${defaultModuleName}(${globalModuleId++})`;
} else if (perContextModuleId.has(context)) { } else if (perContextModuleId.has(context)) {
const curId = perContextModuleId.get(context); const curId = perContextModuleId.get(context);
url = `vm:module(${curId})`; url = `${defaultModuleName}(${curId})`;
perContextModuleId.set(context, curId + 1); perContextModuleId.set(context, curId + 1);
} else { } else {
url = 'vm:module(0)'; url = `${defaultModuleName}(0)`;
perContextModuleId.set(context, 1); perContextModuleId.set(context, 1);
} }