From e8bf4d5dea8e9ade5237b6b8957fae075c4436b5 Mon Sep 17 00:00:00 2001 From: suraiyah Date: Fri, 6 Oct 2017 09:45:03 -0700 Subject: [PATCH] doc: fix macosx-firewall suggestion BUILDING Adding back the changes made by commit# 791d560, that suggests running macosx-firewall.sh script after bulid step. These changes were deleted by commit# fc102d0, but they are still applicable. PR-URL: https://github.com/nodejs/node/pull/15829 Reviewed-By: Ryan Graham Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Daniel Bevenius --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index a16b9182e08..e9a6a8faf95 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -88,7 +88,7 @@ On macOS you will need to install the `Xcode Command Line Tools` by running installed, you can find them under the menu `Xcode -> Open Developer Tool -> More Developer Tools...`. This step will install `clang`, `clang++`, and `make`. -* You may want to setup [firewall rules](tools/macosx-firewall.sh) +* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid popups asking to accept incoming network connections when running tests: If the path to your build directory contains a space, the build will likely fail.