1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: move symbols binding into node_symbols.cc

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/25163
Refs: https://github.com/nodejs/node/issues/24961
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit is contained in:
Joyee Cheung 2018-12-19 20:33:20 +08:00
parent bcea74f976
commit e830e2742c
No known key found for this signature in database
GPG Key ID: 92B78A53C8303B8D
3 changed files with 30 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
node.gyp
View File

@ -371,6 +371,7 @@
'src/node_process.cc',
'src/node_serdes.cc',
'src/node_stat_watcher.cc',
'src/node_symbols.cc',
'src/node_trace_events.cc',
'src/node_types.cc',
'src/node_url.cc',

18
src/bootstrapper.cc
View File

@ -135,22 +135,4 @@ void SetupBootstrapObject(Environment* env,
}
#undef BOOTSTRAP_METHOD
namespace symbols {
void Initialize(Local<Object> target,
Local<Value> unused,
Local<Context> context,
void* priv) {
Environment* env = Environment::GetCurrent(context);
#define V(PropertyName, StringValue) \
target->Set(env->context(), \
env->PropertyName()->Name(), \
env->PropertyName()).FromJust();
PER_ISOLATE_SYMBOL_PROPERTIES(V)
#undef V
}
} // namespace symbols
} // namespace node
NODE_MODULE_CONTEXT_AWARE_INTERNAL(symbols, node::symbols::Initialize)

29
src/node_symbols.cc Normal file
View File

@ -0,0 +1,29 @@
#include "env-inl.h"
#include "node_binding.h"
namespace node {
using v8::Context;
using v8::Local;
using v8::Object;
using v8::Value;
namespace symbols {
static void Initialize(Local<Object> target,
Local<Value> unused,
Local<Context> context,
void* priv) {
Environment* env = Environment::GetCurrent(context);
#define V(PropertyName, StringValue) \
target \
->Set(env->context(), env->PropertyName()->Name(), env->PropertyName()) \
.FromJust();
PER_ISOLATE_SYMBOL_PROPERTIES(V)
#undef V
}
} // namespace symbols
} // namespace node
NODE_MODULE_CONTEXT_AWARE_INTERNAL(symbols, node::symbols::Initialize)