1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: clean up repl-reset-event file

Browse Source 
* Change vars to let/const
* Add mustCall
* equal -> strictEqual
* remove timeout

PR-URL: https://github.com/nodejs/node/pull/9931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Kailean Courtney 2016-12-01 10:33:36 -06:00 committed by James M Snell
parent ff88a5a25b
commit e81e031af7
1 changed files with 22 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
test/parallel/test-repl-reset-event.js
View File

@ -1,52 +1,49 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
common.globalCheck = false; common.globalCheck = false;
var assert = require('assert'); const assert = require('assert');
var repl = require('repl'); const repl = require('repl');
// Create a dummy stream that does nothing // Create a dummy stream that does nothing
const dummy = new common.ArrayStream(); const dummy = new common.ArrayStream();
function testReset(cb) { function testReset(cb) {
var r = repl.start({ const r = repl.start({
input: dummy, input: dummy,
output: dummy, output: dummy,
useGlobal: false useGlobal: false
}); });
r.context.foo = 42; r.context.foo = 42;
r.on('reset', function(context) { r.on('reset', common.mustCall(function(context) {
assert(!!context, 'REPL did not emit a context with reset event'); assert(!!context, 'REPL did not emit a context with reset event');
assert.equal(context, r.context, 'REPL emitted incorrect context'); assert.strictEqual(context, r.context, 'REPL emitted incorrect context');
assert.equal(context.foo, undefined, 'REPL emitted the previous context' + assert.strictEqual(
', and is not using global as context'); context.foo,
undefined,
'REPL emitted the previous context, and is not using global as context'
);
context.foo = 42; context.foo = 42;
cb(); cb();
}); }));
r.resetContext(); r.resetContext();
} }
function testResetGlobal(cb) { function testResetGlobal() {
var r = repl.start({ const r = repl.start({
input: dummy, input: dummy,
output: dummy, output: dummy,
useGlobal: true useGlobal: true
}); });
r.context.foo = 42; r.context.foo = 42;
r.on('reset', function(context) { r.on('reset', common.mustCall(function(context) {
assert.equal(context.foo, 42, assert.strictEqual(
'"foo" property is missing from REPL using global as context'); context.foo,
cb(); 42,
}); '"foo" property is missing from REPL using global as context'
);
}));
r.resetContext(); r.resetContext();
} }
var timeout = setTimeout(function() { testReset(common.mustCall(testResetGlobal));
common.fail('Timeout, REPL did not emit reset events');
}, 5000);
testReset(function() {
testResetGlobal(function() {
clearTimeout(timeout);
});
});