1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: do not use posix feature macro in node.h

Browse Source 
This macro is only defined when building Node.js, so addons cannot
use it as a way of detecting feature availability.

PR-URL: https://github.com/nodejs/node/pull/27775
Refs: https://github.com/nodejs/node/pull/27246
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Anna Henningsen 2019-05-20 01:55:27 +02:00
parent 282e2f669c
commit e6b3ec3d3c
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/node.h
View File

@ -66,9 +66,11 @@
#include <memory> #include <memory>
#ifdef __POSIX__ // We cannot use __POSIX__ in this header because that's only defined when
// building Node.js.
#ifndef _WIN32
#include <signal.h> #include <signal.h>
#endif // __POSIX__ #endif // _WIN32
#define NODE_MAKE_VERSION(major, minor, patch) \ #define NODE_MAKE_VERSION(major, minor, patch) \
((major) * 0x1000 + (minor) * 0x100 + (patch)) ((major) * 0x1000 + (minor) * 0x100 + (patch))
@ -812,7 +814,7 @@ class NODE_EXTERN AsyncResource {
async_context async_context_; async_context async_context_;
}; };
#ifdef __POSIX__ #ifndef _WIN32
// Register a signal handler without interrupting // Register a signal handler without interrupting
// any handlers that node itself needs. // any handlers that node itself needs.
NODE_EXTERN NODE_EXTERN
@ -821,7 +823,7 @@ void RegisterSignalHandler(int signal,
siginfo_t* info, siginfo_t* info,
void* ucontext), void* ucontext),
bool reset_handler = false); bool reset_handler = false);
#endif // __POSIX__ #endif // _WIN32
} // namespace node } // namespace node