1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: accept expected AIX result test-stdio-closed

Browse Source 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: https://github.com/nodejs/node/issues/8375
PR-URL: https://github.com/nodejs/node/pull/8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This commit is contained in:
Rich Trott 2016-09-23 16:41:21 -07:00 committed by James M Snell
parent 8de92cd6f3
commit e65a2d7ddc
2 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/parallel/parallel.status
View File

@ -26,8 +26,5 @@ prefix parallel
test-fs-watch-enoent : FAIL, PASS test-fs-watch-enoent : FAIL, PASS
test-fs-watch-encoding : FAIL, PASS test-fs-watch-encoding : FAIL, PASS
#being worked under https://github.com/nodejs/node/issues/7973
test-stdio-closed : PASS, FLAKY
#covered by https://github.com/nodejs/node/issues/8271 #covered by https://github.com/nodejs/node/issues/8271
test-child-process-fork-dgram : PASS, FLAKY test-child-process-fork-dgram : PASS, FLAKY

22
test/parallel/test-stdio-closed.js
View File

@ -1,7 +1,7 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
if (common.isWindows) { if (common.isWindows) {
common.skip('platform not supported.'); common.skip('platform not supported.');
@ -9,18 +9,28 @@ if (common.isWindows) {
} }
if (process.argv[2] === 'child') { if (process.argv[2] === 'child') {
try {
process.stdout.write('stdout', function() { process.stdout.write('stdout', function() {
try {
process.stderr.write('stderr', function() { process.stderr.write('stderr', function() {
process.exit(42); process.exit(42);
}); });
} catch (e) {
process.exit(84);
}
}); });
} catch (e) {
assert.strictEqual(e.code, 'EBADF');
assert.strictEqual(e.message, 'EBADF: bad file descriptor, write');
process.exit(126);
}
return; return;
} }
// Run the script in a shell but close stdout and stderr. // Run the script in a shell but close stdout and stderr.
var cmd = `"${process.execPath}" "${__filename}" child 1>&- 2>&-`; const cmd = `"${process.execPath}" "${__filename}" child 1>&- 2>&-`;
var proc = spawn('/bin/sh', ['-c', cmd], { stdio: 'inherit' }); const proc = spawn('/bin/sh', ['-c', cmd], { stdio: 'inherit' });
proc.on('exit', common.mustCall(function(exitCode) { proc.on('exit', common.mustCall(function(exitCode) {
assert.equal(exitCode, 42); assert.strictEqual(exitCode, common.isAix ? 126 : 42);
})); }));