1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: simplify 'processChunkSync'

Browse Source 
According to the real logic codes, it seems no matter whether 'nread >=
kMaxLength' or not. We always close the 'self' stream first. So we can
shorten it by merging them into one sample.

PR-URL: https://github.com/nodejs/node/pull/22802
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
This commit is contained in:
MaleDong 2018-09-11 11:55:03 +08:00 committed by Anna Henningsen
parent 0827c80920
commit e636addc3f
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/zlib.js
View File

@ -527,14 +527,12 @@ function processChunkSync(self, chunk, flushFlag) {
}
self.bytesWritten = inputRead;
_close(self);
if (nread >= kMaxLength) {
_close(self);
throw new ERR_BUFFER_TOO_LARGE();
}
_close(self);
if (nread === 0)
return Buffer.alloc(0);