1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cluster: improve for-loop

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/26336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
gengjiawen 2019-02-27 23:12:33 +08:00 committed by Ruben Bridgewater
parent d79176a3c3
commit e630569883
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/internal/cluster/master.js
View File

@ -80,10 +80,7 @@ cluster.setupMaster = function(options) {
if (message.cmd !== 'NODE_DEBUG_ENABLED') if (message.cmd !== 'NODE_DEBUG_ENABLED')
return; return;
var key; for (const worker of Object.values(cluster.workers)) {
for (key in cluster.workers) {
const worker = cluster.workers[key];
if (worker.state === 'online' || worker.state === 'listening') { if (worker.state === 'online' || worker.state === 'listening') {
process._debugProcess(worker.process.pid); process._debugProcess(worker.process.pid);
} else { } else {
@ -227,11 +224,10 @@ cluster.disconnect = function(cb) {
if (workers.length === 0) { if (workers.length === 0) {
process.nextTick(() => intercom.emit('disconnect')); process.nextTick(() => intercom.emit('disconnect'));
} else { } else {
for (var key in workers) { for (const worker of Object.values(cluster.workers)) {
key = workers[key]; if (worker.isConnected()) {
worker.disconnect();
if (cluster.workers[key].isConnected()) }
cluster.workers[key].disconnect();
} }
} }