1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

trace_events: add version metadata

Browse Source 
Use `TRACE_EVENT_METADATA1` to include just the node.js version for
now. Later this can be expanded to include more version and platform
details.

PR-URL: https://github.com/nodejs/node/pull/20852
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
James M Snell 2018-05-20 09:07:37 -07:00
parent 0baad8f0eb
commit e60eed19be
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/node.cc
View File

@ -4322,6 +4322,7 @@ inline int Start(Isolate* isolate, IsolateData* isolate_data,
Environment env(isolate_data, context, v8_platform.GetTracingAgent()); Environment env(isolate_data, context, v8_platform.GetTracingAgent());
env.Start(argc, argv, exec_argc, exec_argv, v8_is_profiling); env.Start(argc, argv, exec_argc, exec_argv, v8_is_profiling);
TRACE_EVENT_METADATA1("__metadata", "version", "node", NODE_VERSION_STRING);
TRACE_EVENT_METADATA1("__metadata", "thread_name", "name", TRACE_EVENT_METADATA1("__metadata", "thread_name", "name",
"JavaScriptMainThread"); "JavaScriptMainThread");

6
test/parallel/test-trace-events-metadata.js
View File

@ -13,7 +13,8 @@ tmpdir.refresh();
process.chdir(tmpdir.path); process.chdir(tmpdir.path);
const proc = cp.spawn(process.execPath, const proc = cp.spawn(process.execPath,
[ '--trace-events-enabled', '-e', CODE ]); [ '--trace-event-categories', 'node.perf.usertiming',
'-e', CODE ]);
proc.once('exit', common.mustCall(() => { proc.once('exit', common.mustCall(() => {
assert(common.fileExists(FILE_NAME)); assert(common.fileExists(FILE_NAME));
fs.readFile(FILE_NAME, common.mustCall((err, data) => { fs.readFile(FILE_NAME, common.mustCall((err, data) => {
@ -25,5 +26,8 @@ proc.once('exit', common.mustCall(() => {
assert(traces.some((trace) => assert(traces.some((trace) =>
trace.cat === '__metadata' && trace.name === 'thread_name' && trace.cat === '__metadata' && trace.name === 'thread_name' &&
trace.args.name === 'BackgroundTaskRunner')); trace.args.name === 'BackgroundTaskRunner'));
assert(traces.some((trace) =>
trace.cat === '__metadata' && trace.name === 'version' &&
trace.args.node === process.versions.node));
})); }));
})); }));