1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: don't emit 'data' after 'error'

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/28711
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Robert Nagy 2019-07-16 01:06:01 +02:00 committed by Rich Trott
parent 1665a9330c
commit e573c39b88
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/_http_client.js
View File

@ -406,9 +406,6 @@ function socketErrorListener(err) {
req.emit('error', err); req.emit('error', err);
} }
// Handle any pending data
socket.read();
const parser = socket.parser; const parser = socket.parser;
if (parser) { if (parser) {
parser.finish(); parser.finish();

3
test/parallel/test-http-client-read-in-error.js
View File

@ -1,5 +1,5 @@
'use strict'; 'use strict';
require('../common'); const common = require('../common');
const net = require('net'); const net = require('net');
const http = require('http'); const http = require('http');
@ -37,4 +37,5 @@ http.request({
agent agent
}).once('error', function() { }).once('error', function() {
console.log('ignore'); console.log('ignore');
this.on('data', common.mustNotCall());
}); });