1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor fs.open parameter handling

Browse Source 
Improvements:
* Removes an unnecessary variable
* Avoids having two variables with the same name
* Avoids re-declaring an existing parameter
* Removes an unnecessary ternary operator
* Avoid an inline short-circuit expression for greater clarity.
This commit is contained in:
Felix Geisendörfer 2011-02-15 08:47:30 -05:00 committed by Ryan Dahl
parent aabdd5d045
commit e56ee67e13
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/fs.js
View File

@ -185,12 +185,14 @@ function modeNum(m, def) {
} }
fs.open = function(path, flags, mode, callback) { fs.open = function(path, flags, mode, callback) {
var callback_ = arguments[arguments.length - 1]; callback = arguments[arguments.length - 1];
var callback = (typeof(callback_) == 'function' ? callback_ : null); if (typeof(callback) !== 'function') {
callback = noop;
}
mode = modeNum(mode, '0666'); mode = modeNum(mode, '0666');
binding.open(path, stringToFlags(flags), mode, callback || noop); binding.open(path, stringToFlags(flags), mode, callback);
}; };
fs.openSync = function(path, flags, mode) { fs.openSync = function(path, flags, mode) {