1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-stream-pipe-error-handling

Browse Source 
* provide a RegExp for second argument to `assert.throws()`
* remove unused function arguments
* provide duration of 1 ms for `setTimeout()` calls that do not have a
  duration

PR-URL: https://github.com/nodejs/node/pull/10530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Rich Trott 2016-12-29 21:19:36 -08:00
parent b465cd07fe
commit e5674e1c04
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-stream-pipe-error-handling.js
View File

@ -50,8 +50,8 @@ const Stream = require('stream').Stream;
assert(removed);
assert.throws(function() {
w.emit('error', new Error('fail'));
});
}));
}, /^Error: fail$/);
}), 1);
});
w.on('error', myOnError);
@ -59,7 +59,7 @@ const Stream = require('stream').Stream;
w.removeListener('error', myOnError);
removed = true;
function myOnError(er) {
function myOnError() {
throw new Error('this should not happen');
}
}
@ -76,10 +76,10 @@ const Stream = require('stream').Stream;
setTimeout(common.mustCall(function() {
assert(removed);
w.emit('error', new Error('fail'));
}));
}), 1);
});
w.on('error', common.mustCall(function(er) {}));
w.on('error', common.mustCall(function() {}));
w._write = function() {};
r.pipe(w);