1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: remove unused functions and add todos

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/58143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This commit is contained in:
Yagiz Nizipli 2025-05-08 22:07:04 -04:00 committed by GitHub
parent e532c86121
commit e46fb17ecb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/node_http_parser.cc
View File

@ -563,7 +563,7 @@ class Parser : public AsyncWrap, public StreamListener {
new Parser(binding_data, args.This());
}
// TODO(@anonrig): Add V8 Fast API
static void Close(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
@ -571,7 +571,7 @@ class Parser : public AsyncWrap, public StreamListener {
delete parser;
}
// TODO(@anonrig): Add V8 Fast API
static void Free(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
@ -582,6 +582,7 @@ class Parser : public AsyncWrap, public StreamListener {
parser->EmitDestroy();
}
// TODO(@anonrig): Add V8 Fast API
static void Remove(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
@ -694,6 +695,7 @@ class Parser : public AsyncWrap, public StreamListener {
}
}
// TODO(@anonrig): Add V8 Fast API
template <bool should_pause>
static void Pause(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
@ -709,7 +711,7 @@ class Parser : public AsyncWrap, public StreamListener {
}
}
// TODO(@anonrig): Add V8 Fast API
static void Consume(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
@ -719,7 +721,7 @@ class Parser : public AsyncWrap, public StreamListener {
stream->PushStreamListener(parser);
}
// TODO(@anonrig): Add V8 Fast API
static void Unconsume(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
@ -745,26 +747,6 @@ class Parser : public AsyncWrap, public StreamListener {
}
}
static void Duration(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
if (parser->last_message_start_ == 0) {
args.GetReturnValue().Set(0);
return;
}
double duration = (uv_hrtime() - parser->last_message_start_) / 1e6;
args.GetReturnValue().Set(duration);
}
static void HeadersCompleted(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
args.GetReturnValue().Set(parser->headers_completed_);
}
protected:
static const size_t kAllocBufferSize = 64 * 1024;
@ -1317,8 +1299,6 @@ void CreatePerIsolateProperties(IsolateData* isolate_data,
SetProtoMethod(isolate, t, "consume", Parser::Consume);
SetProtoMethod(isolate, t, "unconsume", Parser::Unconsume);
SetProtoMethod(isolate, t, "getCurrentBuffer", Parser::GetCurrentBuffer);
SetProtoMethod(isolate, t, "duration", Parser::Duration);
SetProtoMethod(isolate, t, "headersCompleted", Parser::HeadersCompleted);
SetConstructorFunction(isolate, target, "HTTPParser", t);
@ -1388,8 +1368,6 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
registry->Register(Parser::Consume);
registry->Register(Parser::Unconsume);
registry->Register(Parser::GetCurrentBuffer);
registry->Register(Parser::Duration);
registry->Register(Parser::HeadersCompleted);
registry->Register(ConnectionsList::New);
registry->Register(ConnectionsList::All);
registry->Register(ConnectionsList::Idle);