1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: edit pull request template

Browse Source 
Move checklist instructions closer to the checklist. Trim unnecessary
words.

PR-URL: https://github.com/nodejs/node/pull/7058
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
This commit is contained in:
Rich Trott 2016-05-29 22:32:12 -07:00
parent 85da963dda
commit e350deb1e3
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,9 +1,7 @@
<!-- <!--
Thank you for your pull request. Please review below requirements and walk Thank you for your pull request. Please review below requirements.
through the checklist. You can 'tick' a box by using the letter "x": [x].
Run the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on Run tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows.
Windows.
If this aims to fix a regression or you’re adding a feature, make sure you also If this aims to fix a regression or you’re adding a feature, make sure you also
write a test. If possible, include a benchmark that quantifies your changes. write a test. If possible, include a benchmark that quantifies your changes.
@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
--> -->
##### Checklist ##### Checklist
<!-- remove lines that do not apply to you --> <!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [ ] tests and code linting passes - [ ] tests and code linting passes
- [ ] a test and/or benchmark is included - [ ] a test and/or benchmark is included