1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix test-internal-util-assertCrypto regex

Browse Source 
When building --without-ssl and then running:

out/Release/node --expose-internals
test/parallel/test-internal-util-assertCrypto.js

The following error is displayed:
assert.js:420
    throw actual;
    ^

Error: Node.js is not compiled with openssl crypto support
    at Object.exports.assertCrypto (internal/util.js:82:11)
    at assert.throws
(/Users/danielbevenius/work/nodejs/node/test/parallel/test-internal-util-assertCrypto.js:8:28)
    at _tryBlock (assert.js:379:5)
    at _throws (assert.js:398:12)
    at Function.throws (assert.js:428:3)
    at Object.<anonymous>
(/Users/danielbevenius/work/nodejs/node/test/parallel/test-internal-util-assertCrypto.js:8:10)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)

It looks like the regex is not taking into account the 'Error: ' hence
the failure to match it.

PR-URL: https://github.com/nodejs/node/pull/11620
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Daniel Bevenius 2017-02-28 20:33:12 +01:00
parent e1d8899c28
commit e317a616a9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-internal-util-assertCrypto.js
View File

@ -6,7 +6,7 @@ const util = require('internal/util');
if (!process.versions.openssl) {
assert.throws(() => util.assertCrypto(),
/^Node.js is not compiled with openssl crypto support$/);
/^Error: Node.js is not compiled with openssl crypto support$/);
} else {
assert.doesNotThrow(() => util.assertCrypto());
}