1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: make OutgoingMessage._flush inline-able

Browse Source
This commit is contained in:
isaacs 2013-08-15 08:54:49 -07:00
parent da93d6adfb
commit e3157972e1
1 changed files with 34 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/_http_outgoing.js
View File

@ -525,7 +525,6 @@ OutgoingMessage.prototype._finish = function() {
}; };
OutgoingMessage.prototype._flush = function() {
// This logic is probably a bit confusing. Let me explain a bit: // This logic is probably a bit confusing. Let me explain a bit:
// //
// In both HTTP servers and clients it is possible to queue up several // In both HTTP servers and clients it is possible to queue up several
@ -545,18 +544,13 @@ OutgoingMessage.prototype._flush = function() {
// //
// This function, outgoingFlush(), is called by both the Server and Client // This function, outgoingFlush(), is called by both the Server and Client
// to attempt to flush any pending messages out to the socket. // to attempt to flush any pending messages out to the socket.
OutgoingMessage.prototype._flush = function() {
if (!this.socket) return; if (this.socket && this.socket.writable) {
var ret; var ret;
while (this.output.length) { while (this.output.length) {
if (!this.socket.writable) return; // XXX Necessary?
var data = this.output.shift(); var data = this.output.shift();
var encoding = this.outputEncodings.shift(); var encoding = this.outputEncodings.shift();
var cb = this.outputCallbacks.shift(); var cb = this.outputCallbacks.shift();
ret = this.socket.write(data, encoding, cb); ret = this.socket.write(data, encoding, cb);
} }
@ -567,4 +561,5 @@ OutgoingMessage.prototype._flush = function() {
// This is necessary to prevent https from breaking // This is necessary to prevent https from breaking
this.emit('drain'); this.emit('drain');
} }
}
}; };