1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

util: change items unknown style

Browse Source 
We mainly use <> to visualize special information that is not
directly visible as property.

PR-URL: https://github.com/nodejs/node/pull/20792
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
This commit is contained in:
Ruben Bridgewater 2018-05-17 00:08:50 +02:00
parent 0271b0f203
commit e270ae9f01
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/util.js
View File

@ -610,14 +610,14 @@ function formatValue(ctx, value, recurseTimes, ln) {
if (ctx.showHidden) { if (ctx.showHidden) {
formatter = formatWeakSet; formatter = formatWeakSet;
} else { } else {
extra = '[items unknown]'; extra = '<items unknown>';
} }
} else if (isWeakMap(value)) { } else if (isWeakMap(value)) {
braces[0] = `${getPrefix(constructor, tag)}{`; braces[0] = `${getPrefix(constructor, tag)}{`;
if (ctx.showHidden) { if (ctx.showHidden) {
formatter = formatWeakMap; formatter = formatWeakMap;
} else { } else {
extra = '[items unknown]'; extra = '<items unknown>';
} }
} else if (types.isModuleNamespaceObject(value)) { } else if (types.isModuleNamespaceObject(value)) {
braces[0] = `[${tag}] {`; braces[0] = `[${tag}] {`;

4
test/parallel/test-util-inspect.js
View File

@ -1310,7 +1310,7 @@ util.inspect(process);
assert.strictEqual(out, expect); assert.strictEqual(out, expect);
out = util.inspect(weakMap); out = util.inspect(weakMap);
expect = 'WeakMap { [items unknown] }'; expect = 'WeakMap { <items unknown> }';
assert.strictEqual(out, expect); assert.strictEqual(out, expect);
out = util.inspect(weakMap, { maxArrayLength: 0, showHidden: true }); out = util.inspect(weakMap, { maxArrayLength: 0, showHidden: true });
@ -1334,7 +1334,7 @@ util.inspect(process);
assert.strictEqual(out, expect); assert.strictEqual(out, expect);
out = util.inspect(weakSet); out = util.inspect(weakSet);
expect = 'WeakSet { [items unknown] }'; expect = 'WeakSet { <items unknown> }';
assert.strictEqual(out, expect); assert.strictEqual(out, expect);
out = util.inspect(weakSet, { maxArrayLength: -2, showHidden: true }); out = util.inspect(weakSet, { maxArrayLength: -2, showHidden: true });