1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

repl: allow autocompletion for scoped packages

Browse Source 
Previously, autocompletion of scoped packages was not supported by the
repl due to not including the `@` character in the regular expression.

PR-URL: https://github.com/nodejs/node/pull/10296
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Evan Lucas 2016-12-15 17:24:17 -06:00 committed by James M Snell
parent 5acfbb0f25
commit e248f7f9e7
3 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/repl.js
View File

@ -787,7 +787,7 @@ ArrayStream.prototype.writable = true;
ArrayStream.prototype.resume = function() {}; ArrayStream.prototype.resume = function() {};
ArrayStream.prototype.write = function() {}; ArrayStream.prototype.write = function() {};
const requireRE = /\brequire\s*\(['"](([\w./-]+\/)?([\w./-]*))/; const requireRE = /\brequire\s*\(['"](([\w@./-]+\/)?([\w@./-]*))/;
const simpleExpressionRE = const simpleExpressionRE =
/(([a-zA-Z_$](?:\w|\$)*)\.)*([a-zA-Z_$](?:\w|\$)*)\.?$/; /(([a-zA-Z_$](?:\w|\$)*)\.)*([a-zA-Z_$](?:\w|\$)*)\.?$/;

1
test/fixtures/node_modules/@nodejsscope/index.js generated vendored Normal file
View File

@ -0,0 +1 @@
// Not used

21
test/parallel/test-repl-tab-complete.js
View File

@ -1,8 +1,14 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var repl = require('repl');
// We have to change the directory to ../fixtures before requiring repl
// in order to make the tests for completion of node_modules work properly
// since repl modifies module.paths.
process.chdir(common.fixturesDir);
const repl = require('repl');
function getNoResultsFunction() { function getNoResultsFunction() {
return common.mustCall((err, data) => { return common.mustCall((err, data) => {
@ -196,6 +202,15 @@ testMe.complete('require(\'n', common.mustCall(function(error, data) {
}); });
})); }));
{
const expected = ['@nodejsscope', '@nodejsscope/'];
putIn.run(['.clear']);
testMe.complete('require(\'@nodejs', common.mustCall((err, data) => {
assert.strictEqual(err, null);
assert.deepStrictEqual(data, [expected, '@nodejs']);
}));
}
// Make sure tab completion works on context properties // Make sure tab completion works on context properties
putIn.run(['.clear']); putIn.run(['.clear']);