1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix racey-ness in tls-inception

Browse Source 
Fix test failure on FreeBSD and SmartOS, which happens due to a bad
timing:

    events.js:141
          throw er; // Unhandled 'error' event
                ^
    Error: read ECONNRESET
        at exports._errnoException (util.js:734:11)
        at TLSWrap.onread (net.js:538:26)

The outer `net.conncet()` socket stays alive after the inner socket is
gone. This happens because `.pipe()`'s implementation does not `destroy`
the source side when the destination has emitted `close`.

Fix: https://github.com/iojs/io.js/issues/1012
PR-URL: https://github.com/iojs/io.js/pull/1040
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
This commit is contained in:
Fedor Indutny 2015-03-03 04:10:28 -05:00
parent e0835c9cda
commit e1bf6709dc
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-tls-inception.js
View File

@ -28,6 +28,10 @@ a = tls.createServer(options, function (socket) {
var dest = net.connect(options); var dest = net.connect(options);
dest.pipe(socket); dest.pipe(socket);
socket.pipe(dest); socket.pipe(dest);
dest.on('close', function() {
socket.destroy();
});
}); });
// the "target" server // the "target" server