1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove duplicate test-child-process-execfilesync-maxBuffer.js

Browse Source 
In addition correct the comment about what it does.

PR-URL: https://github.com/nodejs/node/pull/28139
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Joyee Cheung 2019-06-09 21:11:56 +08:00
parent 1f143b8625
commit e0fa30fc51
No known key found for this signature in database
GPG Key ID: 92B78A53C8303B8D
2 changed files with 23 additions and 75 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
test/parallel/test-child-process-execfilesync-maxBuffer.js
View File

@ -1,50 +0,0 @@
'use strict';
require('../common');
// This test checks that the maxBuffer option for child_process.spawnFileSync()
// works as expected.
const assert = require('assert');
const { execFileSync } = require('child_process');
const msgOut = 'this is stdout';
const msgOutBuf = Buffer.from(`${msgOut}\n`);
const args = [
'-e',
`console.log("${msgOut}");`
];
// Verify that an error is returned if maxBuffer is surpassed.
{
assert.throws(() => {
execFileSync(process.execPath, args, { maxBuffer: 1 });
}, (e) => {
assert.ok(e, 'maxBuffer should error');
assert.strictEqual(e.errno, 'ENOBUFS');
// We can have buffers larger than maxBuffer because underneath we alloc 64k
// that matches our read sizes.
assert.deepStrictEqual(e.stdout, msgOutBuf);
return true;
});
}
// Verify that a maxBuffer size of Infinity works.
{
const ret = execFileSync(process.execPath, args, { maxBuffer: Infinity });
assert.deepStrictEqual(ret, msgOutBuf);
}
// Default maxBuffer size is 1024 * 1024.
{
assert.throws(() => {
execFileSync(
process.execPath,
['-e', "console.log('a'.repeat(1024 * 1024))"]
);
}, (e) => {
assert.ok(e, 'maxBuffer should error');
assert.strictEqual(e.errno, 'ENOBUFS');
return true;
});
}

48
test/parallel/test-child-process-execfilesync-maxbuf.js
View File

@ -1,11 +1,11 @@
'use strict'; 'use strict';
require('../common'); require('../common');
// This test checks that the maxBuffer option for child_process.spawnSync() // This test checks that the maxBuffer option for child_process.execFileSync()
// works as expected. // works as expected.
const assert = require('assert'); const assert = require('assert');
const execFileSync = require('child_process').execFileSync; const { execFileSync } = require('child_process');
const msgOut = 'this is stdout'; const msgOut = 'this is stdout';
const msgOutBuf = Buffer.from(`${msgOut}\n`); const msgOutBuf = Buffer.from(`${msgOut}\n`);
@ -16,15 +16,16 @@ const args = [
// Verify that an error is returned if maxBuffer is surpassed. // Verify that an error is returned if maxBuffer is surpassed.
{ {
assert.throws( assert.throws(() => {
() => execFileSync(process.execPath, args, { maxBuffer: 1 }), execFileSync(process.execPath, args, { maxBuffer: 1 });
(e) => { }, (e) => {
assert.ok(e, 'maxBuffer should error'); assert.ok(e, 'maxBuffer should error');
assert.strictEqual(e.errno, 'ENOBUFS'); assert.strictEqual(e.errno, 'ENOBUFS');
assert.deepStrictEqual(e.stdout, msgOutBuf); // We can have buffers larger than maxBuffer because underneath we alloc 64k
return true; // that matches our read sizes.
} assert.deepStrictEqual(e.stdout, msgOutBuf);
); return true;
});
} }
// Verify that a maxBuffer size of Infinity works. // Verify that a maxBuffer size of Infinity works.
@ -34,19 +35,16 @@ const args = [
assert.deepStrictEqual(ret, msgOutBuf); assert.deepStrictEqual(ret, msgOutBuf);
} }
// maxBuffer size is 1024 * 1024 at default. // Default maxBuffer size is 1024 * 1024.
{ {
assert.throws( assert.throws(() => {
() => { execFileSync(
execFileSync( process.execPath,
process.execPath, ['-e', "console.log('a'.repeat(1024 * 1024))"]
['-e', "console.log('a'.repeat(1024 * 1024))"], );
{ encoding: 'utf-8' } }, (e) => {
); assert.ok(e, 'maxBuffer should error');
}, (e) => { assert.strictEqual(e.errno, 'ENOBUFS');
assert.ok(e, 'maxBuffer should error'); return true;
assert.strictEqual(e.errno, 'ENOBUFS'); });
return true;
}
);
} }