1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve assert messages in napi exception test

Browse Source 
Include unexpected value in assertion messages.

PR-URL: https://github.com/nodejs/node/pull/16820
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Paul Blanche 2017-11-06 16:27:05 +01:00 committed by Rich Trott
parent 7d9976237a
commit e04d23c1fd
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/addons-napi/test_exception/test.js
View File

@ -33,7 +33,8 @@ assert.strictEqual(test_exception.wasPending(), true,
// Test that the native side does not capture a non-existing exception
returnedError = test_exception.returnException(common.mustCall());
assert.strictEqual(undefined, returnedError,
'Returned error is undefined when no exception is thrown');
'Returned error should be undefined when no exception is' +
` thrown, but ${returnedError} was passed`);
// Test that no exception appears that was not thrown by us
try {
@ -42,7 +43,8 @@ try {
caughtError = anError;
}
assert.strictEqual(undefined, caughtError,
'No exception originated on the native side');
'No exception originated on the native side, but' +
` ${caughtError} was passed`);
// Test that the exception state remains clear when no exception is thrown
assert.strictEqual(test_exception.wasPending(), false,