1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: Simplify IncomingMessage._dump method

Browse Source
This commit is contained in:
isaacs 2013-08-15 11:15:10 -07:00
parent 7c9b607048
commit df23ce138f
2 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/_http_incoming.js
View File

@ -23,14 +23,14 @@ var util = require('util');
var Stream = require('stream'); var Stream = require('stream');
function readStart(socket) { function readStart(socket) {
if (!socket || !socket._handle || !socket._handle.readStart) return; if (socket)
socket._handle.readStart(); socket.resume();
} }
exports.readStart = readStart; exports.readStart = readStart;
function readStop(socket) { function readStop(socket) {
if (!socket || !socket._handle || !socket._handle.readStop) return; if (socket)
socket._handle.readStop(); socket.pause();
} }
exports.readStop = readStop; exports.readStop = readStop;
@ -196,9 +196,6 @@ IncomingMessage.prototype._addHeaderLine = function(field, value, dest) {
IncomingMessage.prototype._dump = function() { IncomingMessage.prototype._dump = function() {
if (!this._dumped) { if (!this._dumped) {
this._dumped = true; this._dumped = true;
if (this.socket.parser) this.socket.parser.incoming = null; this.resume();
this.push(null);
readStart(this.socket);
this.read();
} }
}; };

5
test/simple/test-http-byteswritten.js
View File

@ -58,9 +58,6 @@ var httpServer = http.createServer(function(req, res) {
}); });
httpServer.listen(common.PORT, function() { httpServer.listen(common.PORT, function() {
// XXX(isaacs): This should not be necessary. http.get({ port: common.PORT });
http.get({ port: common.PORT }, function(res) {
res.resume();
});
}); });