1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: don't check the # of chunks in test-http-1.0

Browse Source 
As it can happen that the HTTP response is received in more than
one TCP chunk.

PR-URL: https://github.com/nodejs/node/pull/3961
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
This commit is contained in:
Santiago Gimeno 2015-11-21 22:29:37 +01:00 committed by Ben Noordhuis
parent de2fd63612
commit dde2012cfa
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/parallel/test-http-1.0.js
View File

@ -13,10 +13,7 @@ function test(handler, request_generator, response_validator) {
var server = http.createServer(handler); var server = http.createServer(handler);
var client_got_eof = false; var client_got_eof = false;
var server_response = { var server_response = '';
data: '',
chunks: []
};
function cleanup() { function cleanup() {
server.close(); server.close();
@ -36,8 +33,7 @@ function test(handler, request_generator, response_validator) {
}); });
c.on('data', function(chunk) { c.on('data', function(chunk) {
server_response.data += chunk; server_response += chunk;
server_response.chunks.push(chunk);
}); });
c.on('end', function() { c.on('end', function() {
@ -65,7 +61,7 @@ function test(handler, request_generator, response_validator) {
} }
function response_validator(server_response, client_got_eof, timed_out) { function response_validator(server_response, client_got_eof, timed_out) {
var m = server_response.data.split('\r\n\r\n'); var m = server_response.split('\r\n\r\n');
assert.equal(m[1], body); assert.equal(m[1], body);
assert.equal(true, client_got_eof); assert.equal(true, client_got_eof);
assert.equal(false, timed_out); assert.equal(false, timed_out);
@ -107,8 +103,7 @@ function test(handler, request_generator, response_validator) {
'\r\n' + '\r\n' +
'Hello, world!'); 'Hello, world!');
assert.equal(expected_response, server_response.data); assert.equal(expected_response, server_response);
assert.equal(1, server_response.chunks.length);
assert.equal(true, client_got_eof); assert.equal(true, client_got_eof);
assert.equal(false, timed_out); assert.equal(false, timed_out);
} }
@ -151,8 +146,7 @@ function test(handler, request_generator, response_validator) {
'0\r\n' + '0\r\n' +
'\r\n'); '\r\n');
assert.equal(expected_response, server_response.data); assert.equal(expected_response, server_response);
assert.equal(1, server_response.chunks.length);
assert.equal(true, client_got_eof); assert.equal(true, client_got_eof);
assert.equal(false, timed_out); assert.equal(false, timed_out);
} }