1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tls: don't shadow the tls global with a local

Browse Source 
`tls` shadows the global `tls` require, and isn't indicative of the
arument type.

PR-URL: https://github.com/nodejs/node/pull/25861
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Sam Roberts 2019-01-31 14:07:36 -08:00
parent 24ea4a3452
commit ddd6c21046
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/_tls_wrap.js
View File

@ -280,19 +280,19 @@ function onerror(err) {
// Used by both client and server TLSSockets to start data flowing from _handle, // Used by both client and server TLSSockets to start data flowing from _handle,
// read(0) causes a StreamBase::ReadStart, via Socket._read. // read(0) causes a StreamBase::ReadStart, via Socket._read.
function initRead(tls, socket) { function initRead(tlsSocket, socket) {
// If we were destroyed already don't bother reading // If we were destroyed already don't bother reading
if (!tls._handle) if (!tlsSocket._handle)
return; return;
// Socket already has some buffered data - emulate receiving it // Socket already has some buffered data - emulate receiving it
if (socket && socket.readableLength) { if (socket && socket.readableLength) {
var buf; var buf;
while ((buf = socket.read()) !== null) while ((buf = socket.read()) !== null)
tls._handle.receive(buf); tlsSocket._handle.receive(buf);
} }
tls.read(0); tlsSocket.read(0);
} }
/** /**