From ddcc00bc1e8cc5815c942e1c4713ce92e7a27d40 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 7 Mar 2018 19:59:23 +0100 Subject: [PATCH] async_hooks: don't set hook_fields[kTotals] to 0 This commit removes the setting of hook_field[kTotals] to szero in AsyncHook's enable function. As far as I can tell this would not be required if the setting of this field is done with the assignment operator instead of using the addition assignment operator. PR-URL: https://github.com/nodejs/node/pull/19219 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- lib/async_hooks.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/async_hooks.js b/lib/async_hooks.js index 0c425e69458..f32c9131850 100644 --- a/lib/async_hooks.js +++ b/lib/async_hooks.js @@ -74,12 +74,11 @@ class AsyncHook { return this; const prev_kTotals = hook_fields[kTotals]; - hook_fields[kTotals] = 0; // createHook() has already enforced that the callbacks are all functions, // so here simply increment the count of whether each callbacks exists or // not. - hook_fields[kTotals] += hook_fields[kInit] += +!!this[init_symbol]; + hook_fields[kTotals] = hook_fields[kInit] += +!!this[init_symbol]; hook_fields[kTotals] += hook_fields[kBefore] += +!!this[before_symbol]; hook_fields[kTotals] += hook_fields[kAfter] += +!!this[after_symbol]; hook_fields[kTotals] += hook_fields[kDestroy] += +!!this[destroy_symbol]; @@ -102,9 +101,8 @@ class AsyncHook { return this; const prev_kTotals = hook_fields[kTotals]; - hook_fields[kTotals] = 0; - hook_fields[kTotals] += hook_fields[kInit] -= +!!this[init_symbol]; + hook_fields[kTotals] = hook_fields[kInit] -= +!!this[init_symbol]; hook_fields[kTotals] += hook_fields[kBefore] -= +!!this[before_symbol]; hook_fields[kTotals] += hook_fields[kAfter] -= +!!this[after_symbol]; hook_fields[kTotals] += hook_fields[kDestroy] -= +!!this[destroy_symbol];