1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove common.PORT from test-tlswrap

Browse Source 
`test/async-hooks/test/test-tlswrap.js` uses `common.PORT` but
async-hooks tests are run in parallel. Another test using port 0 could
result in a port collision. Remove `common.PORT` from the test.

PR-URL: https://github.com/nodejs/node/pull/15742
Ref: https://github.com/nodejs/node/issues/14404#issuecomment-333672346
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-10-02 14:37:32 -07:00
parent 9569ca8721
commit ddbf07ab89
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/async-hooks/test-tlswrap.js
View File

@ -25,7 +25,7 @@ const server = tls
}) })
.on('listening', common.mustCall(onlistening)) .on('listening', common.mustCall(onlistening))
.on('secureConnection', common.mustCall(onsecureConnection)) .on('secureConnection', common.mustCall(onsecureConnection))
.listen(common.PORT); .listen(0);
let svr, client; let svr, client;
function onlistening() { function onlistening() {
@ -33,7 +33,7 @@ function onlistening() {
// Creating client and connecting it to server // Creating client and connecting it to server
// //
tls tls
.connect(common.PORT, { rejectUnauthorized: false }) .connect(server.address().port, { rejectUnauthorized: false })
.on('secureConnect', common.mustCall(onsecureConnect)); .on('secureConnect', common.mustCall(onsecureConnect));
const as = hooks.activitiesOfTypes('TLSWRAP'); const as = hooks.activitiesOfTypes('TLSWRAP');