1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: bind to 0 in dgram-send-callback-buffer-length

Browse Source 
Remove common.PORT from test-dgram-send-callback-buffer-length to
eliminate possibility that a dynamic port used in another test will
collide with common.PORT.

PR-URL: https://github.com/nodejs/node/pull/12943
Refs: https://github.com/nodejs/node/issues/12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
This commit is contained in:
Artur Vieira 2017-05-10 02:26:50 +00:00 committed by Luigi Pinca
parent 281de19a8c
commit dd3c227796
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/parallel/test-dgram-send-callback-buffer-length.js
View File

@ -38,4 +38,7 @@ const messageSent = common.mustCall(function messageSent(err, bytes) {
client.close();
});
client.send(buf, offset, len, common.PORT, '127.0.0.1', messageSent);
client.bind(0, () => client.send(buf, offset, len,
client.address().port,
'127.0.0.1',
messageSent));