lib: move process.binding('js_stream') to internalBinding
PR-URL: https://github.com/nodejs/node/pull/22239 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
parent
9ccf5c8954
commit
dcc0c2c5c9
@ -378,7 +378,8 @@
|
|||||||
'util',
|
'util',
|
||||||
'async_wrap',
|
'async_wrap',
|
||||||
'url',
|
'url',
|
||||||
'spawn_sync']);
|
'spawn_sync',
|
||||||
|
'js_stream']);
|
||||||
process.binding = function binding(name) {
|
process.binding = function binding(name) {
|
||||||
return internalBindingWhitelist.has(name) ?
|
return internalBindingWhitelist.has(name) ?
|
||||||
internalBinding(name) :
|
internalBinding(name) :
|
||||||
|
@ -3,8 +3,8 @@
|
|||||||
const assert = require('assert');
|
const assert = require('assert');
|
||||||
const util = require('util');
|
const util = require('util');
|
||||||
const { Socket } = require('net');
|
const { Socket } = require('net');
|
||||||
const { JSStream } = process.binding('js_stream');
|
|
||||||
const { internalBinding } = require('internal/bootstrap/loaders');
|
const { internalBinding } = require('internal/bootstrap/loaders');
|
||||||
|
const { JSStream } = internalBinding('js_stream');
|
||||||
const uv = internalBinding('uv');
|
const uv = internalBinding('uv');
|
||||||
const debug = util.debuglog('stream_wrap');
|
const debug = util.debuglog('stream_wrap');
|
||||||
const { owner_symbol } = require('internal/async_hooks').symbols;
|
const { owner_symbol } = require('internal/async_hooks').symbols;
|
||||||
|
@ -216,4 +216,4 @@ void JSStream::Initialize(Local<Object> target,
|
|||||||
|
|
||||||
} // namespace node
|
} // namespace node
|
||||||
|
|
||||||
NODE_BUILTIN_MODULE_CONTEXT_AWARE(js_stream, node::JSStream::Initialize)
|
NODE_MODULE_CONTEXT_AWARE_INTERNAL(js_stream, node::JSStream::Initialize)
|
||||||
|
@ -1,8 +1,11 @@
|
|||||||
|
// Flags: --expose-internals
|
||||||
|
|
||||||
'use strict';
|
'use strict';
|
||||||
|
|
||||||
require('../common');
|
require('../common');
|
||||||
const util = require('util');
|
const util = require('util');
|
||||||
const JSStream = process.binding('js_stream').JSStream;
|
const { internalBinding } = require('internal/test/binding');
|
||||||
|
const { JSStream } = internalBinding('js_stream');
|
||||||
|
|
||||||
// Testing if will abort when properties are printed.
|
// Testing if will abort when properties are printed.
|
||||||
util.inspect(new JSStream());
|
util.inspect(new JSStream());
|
||||||
|
@ -14,3 +14,4 @@ assert(process.binding('signal_wrap'));
|
|||||||
assert(process.binding('contextify'));
|
assert(process.binding('contextify'));
|
||||||
assert(process.binding('url'));
|
assert(process.binding('url'));
|
||||||
assert(process.binding('spawn_sync'));
|
assert(process.binding('spawn_sync'));
|
||||||
|
assert(process.binding('js_stream'));
|
||||||
|
@ -20,11 +20,12 @@
|
|||||||
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
||||||
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
||||||
|
|
||||||
|
// Flags: --expose-internals
|
||||||
'use strict';
|
'use strict';
|
||||||
const common = require('../common');
|
const common = require('../common');
|
||||||
const assert = require('assert');
|
const assert = require('assert');
|
||||||
const { internalBinding } = require('internal/test/binding');
|
const { internalBinding } = require('internal/test/binding');
|
||||||
const JSStream = process.binding('js_stream').JSStream;
|
const { JSStream } = internalBinding('js_stream');
|
||||||
const util = require('util');
|
const util = require('util');
|
||||||
const vm = require('vm');
|
const vm = require('vm');
|
||||||
const { previewEntries } = internalBinding('util');
|
const { previewEntries } = internalBinding('util');
|
||||||
|
@ -1,11 +1,12 @@
|
|||||||
// Flags: --experimental-vm-modules
|
// Flags: --experimental-vm-modules --expose-internals
|
||||||
'use strict';
|
'use strict';
|
||||||
require('../common');
|
require('../common');
|
||||||
const fixtures = require('../common/fixtures');
|
const fixtures = require('../common/fixtures');
|
||||||
const assert = require('assert');
|
const assert = require('assert');
|
||||||
const { types, inspect } = require('util');
|
const { types, inspect } = require('util');
|
||||||
const vm = require('vm');
|
const vm = require('vm');
|
||||||
const { JSStream } = process.binding('js_stream');
|
const { internalBinding } = require('internal/test/binding');
|
||||||
|
const { JSStream } = internalBinding('js_stream');
|
||||||
|
|
||||||
const external = (new JSStream())._externalStream;
|
const external = (new JSStream())._externalStream;
|
||||||
const wasmBuffer = fixtures.readSync('test.wasm');
|
const wasmBuffer = fixtures.readSync('test.wasm');
|
||||||
|
@ -1,5 +1,8 @@
|
|||||||
|
// Flags: --expose-gc --expose-internals
|
||||||
|
|
||||||
'use strict';
|
'use strict';
|
||||||
|
|
||||||
|
const { internalBinding } = require('internal/test/binding');
|
||||||
const common = require('../common');
|
const common = require('../common');
|
||||||
const assert = require('assert');
|
const assert = require('assert');
|
||||||
const v8 = require('v8');
|
const v8 = require('v8');
|
||||||
@ -20,7 +23,7 @@ const objects = [
|
|||||||
circular
|
circular
|
||||||
];
|
];
|
||||||
|
|
||||||
const hostObject = new (process.binding('js_stream').JSStream)();
|
const hostObject = new (internalBinding('js_stream').JSStream)();
|
||||||
|
|
||||||
const serializerTypeError =
|
const serializerTypeError =
|
||||||
/^TypeError: Class constructor Serializer cannot be invoked without 'new'$/;
|
/^TypeError: Class constructor Serializer cannot be invoked without 'new'$/;
|
||||||
|
@ -94,7 +94,7 @@ function testInitialized(req, ctor_name) {
|
|||||||
|
|
||||||
|
|
||||||
{
|
{
|
||||||
const JSStream = process.binding('js_stream').JSStream;
|
const JSStream = internalBinding('js_stream').JSStream;
|
||||||
testInitialized(new JSStream(), 'JSStream');
|
testInitialized(new JSStream(), 'JSStream');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user