doc: wrap pull-requests.md at 80 characters
PR-URL: https://github.com/nodejs/node/pull/21361 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
parent
0b27cb4a7c
commit
dc10ddf034
@ -137,8 +137,8 @@ notes about [commit squashing](#commit-squashing)).
|
|||||||
A good commit message should describe what changed and why.
|
A good commit message should describe what changed and why.
|
||||||
|
|
||||||
1. The first line should:
|
1. The first line should:
|
||||||
- contain a short description of the change (preferably 50 characters or less,
|
- contain a short description of the change (preferably 50 characters or
|
||||||
and no more than 72 characters)
|
less, and no more than 72 characters)
|
||||||
- be entirely in lowercase with the exception of proper nouns, acronyms, and
|
- be entirely in lowercase with the exception of proper nouns, acronyms, and
|
||||||
the words that refer to code, like function/variable names
|
the words that refer to code, like function/variable names
|
||||||
- be prefixed with the name of the changed subsystem and start with an
|
- be prefixed with the name of the changed subsystem and start with an
|
||||||
@ -456,7 +456,8 @@ Focus first on the most significant aspects of the change:
|
|||||||
1. Does this change make sense for Node.js?
|
1. Does this change make sense for Node.js?
|
||||||
2. Does this change make Node.js better, even if only incrementally?
|
2. Does this change make Node.js better, even if only incrementally?
|
||||||
3. Are there clear bugs or larger scale issues that need attending to?
|
3. Are there clear bugs or larger scale issues that need attending to?
|
||||||
4. Is the commit message readable and correct? If it contains a breaking change is it clear enough?
|
4. Is the commit message readable and correct? If it contains a breaking change
|
||||||
|
is it clear enough?
|
||||||
|
|
||||||
When changes are necessary, *request* them, do not *demand* them, and do not
|
When changes are necessary, *request* them, do not *demand* them, and do not
|
||||||
assume that the submitter already knows how to add a test or run a benchmark.
|
assume that the submitter already knows how to add a test or run a benchmark.
|
||||||
|
Loading…
x
Reference in New Issue
Block a user