1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: correct buffer changelog ordering

Browse Source 
This commit reorders the function level changelogs of
Buffer.prototype.fill() and Buffer.alloc() to reflect the order
in which the entries were added.

PR-URL: https://github.com/nodejs/node/pull/18129
Fixes: https://github.com/nodejs/node/issues/18128
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This commit is contained in:
cjihrig 2018-01-16 20:13:26 -05:00
parent 1e802539b2
commit dbdcf12187
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
doc/api/buffer.md
View File

@ -511,18 +511,18 @@ console.log(buf2.toString());
<!-- YAML <!-- YAML
added: v5.10.0 added: v5.10.0
changes: changes:
- version: v8.9.3
pr-url: https://github.com/nodejs/node/pull/17428
description: Specifying an invalid string for `fill` now results in a
zero-filled buffer.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/17427
description: Specifying an invalid string for `fill` triggers a thrown
exception.
- version: REPLACEME - version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/18129 pr-url: https://github.com/nodejs/node/pull/18129
description: Attempting to fill a non-zero length buffer with a zero length description: Attempting to fill a non-zero length buffer with a zero length
buffer triggers a thrown exception. buffer triggers a thrown exception.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/17427
description: Specifying an invalid string for `fill` triggers a thrown
exception.
- version: v8.9.3
pr-url: https://github.com/nodejs/node/pull/17428
description: Specifying an invalid string for `fill` now results in a
zero-filled buffer.
--> -->
* `size` {integer} The desired length of the new `Buffer`. * `size` {integer} The desired length of the new `Buffer`.
@ -1228,17 +1228,17 @@ console.log(buf1.equals(buf3));
<!-- YAML <!-- YAML
added: v0.5.0 added: v0.5.0
changes: changes:
- version: v5.7.0
pr-url: https://github.com/nodejs/node/pull/4935
description: The `encoding` parameter is supported now.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/17427
description: Specifying an invalid string for `value` triggers a thrown
exception.
- version: REPLACEME - version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/18129 pr-url: https://github.com/nodejs/node/pull/18129
description: Attempting to fill a non-zero length buffer with a zero length description: Attempting to fill a non-zero length buffer with a zero length
buffer triggers a thrown exception. buffer triggers a thrown exception.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/17427
description: Specifying an invalid string for `value` triggers a thrown
exception.
- version: v5.7.0
pr-url: https://github.com/nodejs/node/pull/4935
description: The `encoding` parameter is supported now.
--> -->
* `value` {string|Buffer|integer} The value to fill `buf` with. * `value` {string|Buffer|integer} The value to fill `buf` with.