From dafd76ca8fa96fc48d9d7c0058a1e3cc9fab1e9b Mon Sep 17 00:00:00 2001 From: NoSkillGirl Date: Sat, 17 Nov 2018 17:23:28 +0530 Subject: [PATCH] test: assertion equality fix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In test-net-write-callback.js, when process exits, we check callback count against the expected value. The assertion is written with the expected value first and actual value second, but that is the opposite of the documented argument order. Reverse them to be consistent with documentation. PR-URL: https://github.com/nodejs/node/pull/24422 Reviewed-By: Michaƫl Zasso Reviewed-By: Gireesh Punathil Reviewed-By: Trivikram Kamat Reviewed-By: Ouyang Yadong Reviewed-By: Colin Ihrig --- test/pummel/test-net-write-callbacks.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/pummel/test-net-write-callbacks.js b/test/pummel/test-net-write-callbacks.js index a4a6096d633..0bcc9e2dec1 100644 --- a/test/pummel/test-net-write-callbacks.js +++ b/test/pummel/test-net-write-callbacks.js @@ -67,5 +67,5 @@ server.listen(common.PORT, function() { }); process.on('exit', function() { - assert.strictEqual(N, cbcount); + assert.strictEqual(cbcount, N); });