build: run lint before tests
Have `make test` run linting tools before tests rather than after. Lint is likely to find issues quickly. Tests may take a while to run. So do the linting first. Refs: https://github.com/nodejs/node/issues/4546#issuecomment-189755007 PR-URL: https://github.com/nodejs/node/pull/5470 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
This commit is contained in:
parent
76e4a74377
commit
d9f7a597e4
2
Makefile
2
Makefile
@ -111,9 +111,9 @@ v8:
|
||||
$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)
|
||||
|
||||
test: | cctest # Depends on 'all'.
|
||||
$(PYTHON) tools/test.py --mode=release message parallel sequential -J
|
||||
$(MAKE) jslint
|
||||
$(MAKE) cpplint
|
||||
$(PYTHON) tools/test.py --mode=release message parallel sequential -J
|
||||
|
||||
test-parallel: all
|
||||
$(PYTHON) tools/test.py --mode=release parallel -J
|
||||
|
Loading…
x
Reference in New Issue
Block a user