1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: expand http2 util test coverage for headers

Browse Source 
Expand existing test cases to hit some additional branches of
toHeaderObject and mapToHeaders.

PR-URL: https://github.com/nodejs/node/pull/15493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Anatoli Papirovski 2017-09-20 08:22:49 -04:00 committed by Ruben Bridgewater
parent d9cc105102
commit d8a226673b
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/parallel/test-http2-cookies.js
View File

@ -11,7 +11,8 @@ const server = h2.createServer();
const setCookie = [ const setCookie = [
'a=b', 'a=b',
'c=d; Wed, 21 Oct 2015 07:28:00 GMT; Secure; HttpOnly' 'c=d; Wed, 21 Oct 2015 07:28:00 GMT; Secure; HttpOnly',
'e=f'
]; ];
// we use the lower-level API here // we use the lower-level API here

6
test/parallel/test-http2-util-headers-list.js
View File

@ -261,4 +261,10 @@ const regex =
})(mapToHeaders({ [name]: 'abc' })); })(mapToHeaders({ [name]: 'abc' }));
}); });
common.expectsError({
code: 'ERR_HTTP2_INVALID_CONNECTION_HEADERS',
message: regex
})(mapToHeaders({ [HTTP2_HEADER_TE]: ['abc'] }));
assert(!(mapToHeaders({ te: 'trailers' }) instanceof Error)); assert(!(mapToHeaders({ te: 'trailers' }) instanceof Error));
assert(!(mapToHeaders({ te: ['trailers'] }) instanceof Error));